support SET <col> = <expr>, ... clause in LOAD DATA
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
reviewed
Sep 9, 2024
There was a problem hiding this comment.
The initial support for the SET clause looks good, but I don't think it's enough to resolve the customer's issue. In their LOAD DATA statement, they are using a feature where they load some of the input file's fields into user vars and then reference those user var in the SET clause to set other columns.
It seems like the SET expression to set the column's value would work already, but I don't think we support loading the values into user vars yet. Either way, we should add tests to cover that use case.
I can approve this one if you want to take it in two steps, otherwise I can take another look at this one after you add in the user var support.
fulghum
approved these changes
Sep 10, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial support for: dolthub/dolt#8307