Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql.ContextProvider interface #2652

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Sep 9, 2024

Doltgres needs a way to get a sql.Context in order to call some functions. This change adds a new sql.ContextProvider interface and has Handler implement it.

See dolthub/doltgresql#685 for the code that needs to call this new interface.

@fulghum fulghum marked this pull request as ready for review September 9, 2024 23:55
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 794fc14 into main Sep 10, 2024
9 checks passed
@fulghum fulghum deleted the fulghum/sql-context-provider branch September 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants