refactor index validation and prevent indexes over json columns #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Apr 29, 2024
| @@ -1806,74 +1806,79 @@ func getCheckAlterableTable(t sql.Table) (sql.CheckAlterableTable, error) { | |||
| } | |||
| } | |||
|
|
|||
| // generateIndexName generates a unique index name based on the columns in the index, and any existing indexes on the table. | |||
| func generateIndexName(ctx *sql.Context, idxAltable sql.IndexAlterableTable, idxColNames []string) (string, error) { | |||
There was a problem hiding this comment.
the comment above that this is different than Dolt's implementation is maybe informative to keep?
There was a problem hiding this comment.
I can't find the deleted comment, but I think I might've been mistaken before.
max-hoffman
reviewed
Apr 29, 2024
max-hoffman
reviewed
Apr 29, 2024
max-hoffman
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the logic to validate if an index.
Additionally, it fixes a bug where
create table t (i int, index (i, i));was allowed.fixes: dolthub/dolt#6064