Update GMS to detect INSERT statements with row alias and return error. #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/insert-as
branch
from
8509d99 to
d10c2b4
Compare
fulghum
approved these changes
Apr 16, 2024
enginetest/queries/insert_queries.go
Outdated
Comment on lines
479
to
492
| /* Disabled, see https://github.com/dolthub/dolt/issues/7638 | ||
| { | ||
| WriteQuery: "INSERT INTO mytable (i,s) values (1, 'hi') AS dt(new_i,new_s) ON DUPLICATE KEY UPDATE s=new_s", | ||
| ExpectedWriteResult: []sql.Row{{types.NewOkResult(2)}}, | ||
| SelectQuery: "SELECT * FROM mytable WHERE i = 1", | ||
| ExpectedSelect: []sql.Row{{int64(1), "hi"}}, | ||
| }, | ||
| { | ||
| WriteQuery: "INSERT INTO mytable (i,s) values (1, 'hi') AS dt ON DUPLICATE KEY UPDATE mytable.s=dt.s", | ||
| ExpectedWriteResult: []sql.Row{{types.NewOkResult(2)}}, | ||
| SelectQuery: "SELECT * FROM mytable WHERE i = 1", | ||
| ExpectedSelect: []sql.Row{{int64(1), "hir"}}, | ||
| }, | ||
| */ |
There was a problem hiding this comment.
Are these the new "insert row aliases are not currently supported" error cases? Can we leave them in and assert they return the new error message? That would be a little better than commenting them out. Alternatively, you could add them as skipped tests somewhere – we do track those skipped tests (James has been doing that lately) so at least they are still visible that way.
There was a problem hiding this comment.
Added a Skip flag to this test type. How does this look?
There was a problem hiding this comment.
Skipped tests look great. Looks like there is a compile error coming from dbr being unknown now though.
nicktobey
force-pushed
the
nicktobey/insert-as
branch
from
c153637 to
cac5222
Compare
nicktobey
force-pushed
the
nicktobey/insert-as
branch
from
62ffbc9 to
91a37eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse these statements but don't yet support them. So for now we return a helpful error.