prevent panic on triggers with declare statements #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Apr 9, 2024
There was a problem hiding this comment.
we chatted a bit about this, but if the goal is to not panic I think it might be safest/easiest to explicitly error in planbuilder when we're building a handler without an appropriate trigger context. Pushing it downstream risk undefined behavior or more panics
max-hoffman
approved these changes
Apr 10, 2024
sql/expression/procedurereference.go
Outdated
| return &ProcedureParam{ | ||
| name: strings.ToLower(name), | ||
| typ: typ, | ||
| //pRef: NewProcedureReference(), |
added 2 commits
April 10, 2024 00:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're reusing a code from stored procedures to handle begin end blocks, but we're missing a lot of set up that prevents certain variables from being nil. Consequently, we panic in a couple places.
This PR fixes some of those panics, but reveals other problems we have in resolving/executing triggers of this format.
Partially addresses: dolthub/dolt#7720