Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix External Index Creation #2300

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

arthurt
Copy link
Contributor

@arthurt arthurt commented Jan 30, 2024

Fixes regression introduced by 9b9301f

Currently

CREATE INDEX foo USING driver table (column)

creates a table scan if driver is not "", "btree" or "hash".

The regression is caused by the change:

-	outScope.node = plan.NewCreateIndex(
+	createIndex := plan.NewCreateIndex(
		ddl.IndexSpec.ToName.String(),
		table,
		cols,
		ddl.IndexSpec.Using.Lowered(),
		config,
	)
+	createIndex.Catalog = b.cat
	return

Fixes regression introduced by 9b9301f
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for helping us catch this one! 🙏

@fulghum
Copy link
Contributor

fulghum commented Feb 9, 2024

Thank you for the contribution @arthurt! Sorry it took us so long to get to this one. Code change looks good to me and all the tests have passed now, so I'll go ahead and merge this one in.

Very good catch here on finding that missing call to set the outScope.node! Thank you for contributing this fix!! 🙏

@fulghum fulghum merged commit c5ba717 into dolthub:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants