Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the ALTER USER statement to change account passwords #2273

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 18, 2024

Adds basic support for the ALTER USER statement, so that users can change passwords. All users are allowed to change their own password; changing another user's password requires the CREATE USER privilege or the UPDATE privilege on the mysql database.

MySQL reference docs for ALTER USER

Related to: dolthub/dolt#7348

@fulghum fulghum requested a review from max-hoffman January 18, 2024 21:51
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'm not too familiar with the auth execution code but seems reasonable to me

@fulghum fulghum merged commit 4ce767f into main Jan 18, 2024
7 checks passed
@fulghum fulghum deleted the fulghum/dolt-7348 branch January 18, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants