Allow ambiguous column names in GroupBy and Having clauses
#2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The MySQL behavior is a bit more complicated than that: I wrote about it here: dolthub/dolt#6676 |
|
I wouldn't worry about fully matching the behavior described in the link though. As long as this only fixes sqllogictests and doesn't break any, then it makes us more correct and that's what matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, MySQL allows ambiguous column names in GroupBy and Having clauses.
They just pick the left most column that matches.
This should fix 14 sqllogictests.
Correctness: dolthub/dolt#7356