implement elt() and field() function
#2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Jan 16, 2024
max-hoffman
reviewed
Jan 16, 2024
| return nil, sql.ErrInvalidArgumentNumber.New("ELT", "2 or more", len(args)) | ||
| } | ||
|
|
||
| return &Elt{args}, nil |
There was a problem hiding this comment.
should we validate the arg types? what happens if one of these isn't a string?
There was a problem hiding this comment.
it looks like non-string types are OK actually, these two both return 2
select field(2, 'a',2);
select field(2, 'a','2');
sql/expression/function/field.go
Outdated
|
|
||
| // Type implements the Expression interface. | ||
| func (f *Field) Type() sql.Type { | ||
| return types.Int32 |
There was a problem hiding this comment.
mysql reports this as a long when I'm testing
There was a problem hiding this comment.
This is what I get when running on MySQL with --column-type-info
mysql> select field('a', 'a');
Field 1
Name: `field('a', 'a')`
Org_name: ``
Catalog: `def`
Database: ``
Table: ``
Org_table: ``
Type: Integer
DbType: TINY
Collation: binary (63)
Length: 3
Decimals: 0
Flags: NOT_NULL NUM
+-----------------+
| field('a', 'a') |
+-----------------+
| 1 |
+-----------------+
1 row in set (0.0003 sec)There was a problem hiding this comment.
This is what i get, mysql 8.0.2
mysql> select field('a', 'a');
Field 1: `field('a', 'a')`
Catalog: `def`
Database: ``
Table: ``
Org_table: ``
Type: LONGLONG
Collation: binary (63)
Length: 3
Max_length: 1
Decimals: 0
Flags: NOT_NULL BINARY NUM
+-----------------+
| field('a', 'a') |
+-----------------+
| 1 |
+-----------------+
max-hoffman
reviewed
Jan 16, 2024
added 3 commits
January 16, 2024 11:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
ELT()function, which just returns the nth argument as a string.This PR also implements the
FIELD()function, which returns the first case-insensitive match to the first argument.MySQL Docs: