Skip to content

Commit

Permalink
Merge pull request #2844 from dolthub/zachmu/skip-transaction-test
Browse files Browse the repository at this point in the history
Correctly skip skipped assertions in transaction tests
  • Loading branch information
zachmu authored Feb 6, 2025
2 parents ace3b04 + cad92ac commit c216e59
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions enginetest/evaluation.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,10 @@ func TestTransactionScriptWithEngine(t *testing.T, e QueryEngine, harness Harnes
t.Skip()
}

if assertion.Skip {
t.Skip()
}

if assertion.ExpectedErr != nil {
AssertErrWithCtx(t, e, harness, clientSession, assertion.Query, assertion.Bindings, assertion.ExpectedErr)
} else if assertion.ExpectedErrStr != "" {
Expand Down

0 comments on commit c216e59

Please sign in to comment.