Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for dolt_ignore per schema #995

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Tests for dolt_ignore per schema #995

merged 6 commits into from
Nov 22, 2024

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Nov 21, 2024

@tbantle22 tbantle22 requested a review from zachmu November 21, 2024 21:06
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Main PR
covering_index_scan_postgres 437.90/s 424.96/s -3.0%
index_join_postgres 165.81/s 164.03/s -1.1%
index_join_scan_postgres 188.50/s 186.55/s -1.1%
index_scan_postgres 15.07/s 14.99/s -0.6%
oltp_point_select 2875.63/s 2880.37/s +0.1%
oltp_read_only 1951.20/s 1943.53/s -0.4%
select_random_points 122.19/s 121.63/s -0.5%
select_random_ranges 92.38/s 93.83/s +1.5%
table_scan_postgres 14.76/s 14.72/s -0.3%
types_table_scan_postgres 7.02/s 6.79/s -3.3%

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbantle22 tbantle22 force-pushed the taylor/ignore-schemas branch from b5a4cc0 to 8347d39 Compare November 21, 2024 22:30
@tbantle22 tbantle22 force-pushed the taylor/rebase-ignore branch from 22f1240 to 9d45504 Compare November 22, 2024 18:42
Base automatically changed from taylor/rebase-ignore to main November 22, 2024 19:12
@tbantle22 tbantle22 marked this pull request as ready for review November 22, 2024 19:30
Copy link
Contributor

Main PR
Total 42090 42090
Successful 14534 14534
Failures 27556 27556
Partial Successes1 4689 4689
Main PR
Successful 34.5308% 34.5308%
Failures 65.4692% 65.4692%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@tbantle22 tbantle22 merged commit 3853635 into main Nov 22, 2024
14 checks passed
@tbantle22 tbantle22 deleted the taylor/ignore-schemas branch November 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants