Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report auto increment changes in dolt diff and dolt_diff_summary() #8910

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

nicktobey
Copy link
Contributor

Potential fix for #8907

Previously, diffs would only look at the schema hash when determining whether or not a table had a schema change. However, the auto increment counter, which is considered part of the schema, is not stored in the schema flatbuffer and thus does not affect the schema hash.

This led to situations where a diff would detect that a table had changed (because the table hash changed), but it reported neither a data change or a schema change (because the data hash and schema hash were the same.) This was confusing.

Now, dolt_diff_summary will correctly report a schema change when the auto increment counter has changed, and dolt diff will show the autoincrement value in the SHOW CREATE TABLE output.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e8b0967 ok 5937457
version total_tests
e8b0967 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9a3082c ok 5937457
version total_tests
9a3082c 5937457
correctness_percentage
100.0

@nicktobey nicktobey merged commit 78215f2 into main Mar 1, 2025
21 checks passed
Copy link

github-actions bot commented Mar 2, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.1 1.2
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.92 3.79 4.55
blob 2 blobs 200000 1 0.91 4.33 4.71
blob no blob 200000 1 0.98 2.27 2.63
col type datetime 200000 1 0.84 2.4 2.67
col type varchar 200000 1 0.7 3.33 3.76
config width 2 cols 200000 1 0.89 2.22 2.57
config width 32 cols 200000 1 1.89 2.01 2.76
config width 8 cols 200000 1 0.98 2.39 2.66
pk type float 200000 1 0.83 2.46 2.92
pk type int 200000 1 0.84 2.38 2.64
pk type varchar 200000 1 1.99 1.3 1.56
row count 1.6mm 1600000 1 5.87 2.89 2.88
row count 400k 400000 1 1.52 2.72 2.84
row count 800k 800000 1 2.92 2.87 2.88
secondary index four index 200000 1 3.69 1.37 1.3
secondary index no secondary 200000 1 0.96 2.3 2.68
secondary index one index 200000 1 1.18 2.36 2.47
secondary index two index 200000 1 2.03 1.76 1.82
sorting shuffled 1mm 1000000 0 5.26 2.75 2.61
sorting sorted 1mm 1000000 1 5.03 2.85 2.73

Copy link

github-actions bot commented Mar 2, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.2
dolt_blame_commit_filter system table 2.97
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 2.77
dolt_diff_log_join_to_commit system table 2.72
dolt_diff_table_from_commit_filter system table 1.18
dolt_diff_table_to_commit_filter system table 1.11
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.29
dolt_log_commit_filter system table 1.17

Copy link

github-actions bot commented Mar 2, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.11
adds_updates_deletes 60000 60000 60000 4.53
deletes_only 0 60000 0 2.45
updates_only 0 0 60000 3.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants