[no-release-notes] go/store/nbs: NomsBlockStore.UpdateManifest{,WithAppendix} pre-open table files before the manifest updates. #8903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppendix} pre-open table files before the manifest updates.
This brings them in line with AddTableFilesToManifest.
UpdateManifest{,WithAppendix} are used by some implementations of
dolt.services.remotesapi.v1alpha1.ChunkStoreService. Opening the table files is
only less efficient if updateManifestAddFiles encounters an error, but it is
safer because it ensures the table files are able to be opened before the added
to the manifest itself. We do not expect updateManifestAddFiles to encounter
errors - its only error condition is an I/O error on updating the manifest
itself, or, previously, errors on opening the newly added table files.
macneale4
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings them in line with AddTableFilesToManifest.
UpdateManifest{,WithAppendix} are used by some implementations of dolt.services.remotesapi.v1alpha1.ChunkStoreService. Opening the table files is only less efficient if updateManifestAddFiles encounters an error, but it is safer because it ensures the table files are able to be opened before the added to the manifest itself. We do not expect updateManifestAddFiles to encounter errors - its only error condition is an I/O error on updating the manifest itself, or, previously, errors on opening the newly added table files.