Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] Account for null values in AddressTypeHandler columns. #8889

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[no-release-notes] Account for null values in AddressTypeHandler columns. #8889

merged 1 commit into from
Feb 25, 2025

Conversation

nicktobey
Copy link
Contributor

The previous PR missed the case where an address column contained NULL values. This was caught in the Doltgres version bump, which has a test for it.

@nicktobey nicktobey requested a review from zachmu February 25, 2025 07:29
@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a63549e ok 5937457
version total_tests
a63549e 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit d316e56 into main Feb 25, 2025
34 of 35 checks passed
@nicktobey nicktobey deleted the nicktobey/textindex2 branch February 25, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicktobey @coffeegoddd @zachmu