Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] archive clone/fetch #8857

Merged
merged 28 commits into from
Feb 14, 2025
Merged

Conversation

macneale4
Copy link
Contributor

@macneale4 macneale4 commented Feb 12, 2025

Enable the remotesrv to vend databases with archive files.

This change is not being included in release notes because there is currently no user facing way to push archives.

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
810b837 ok 5937457
version total_tests
810b837 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5f8903f ok 5937457
version total_tests
5f8903f 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from reltuk February 12, 2025 20:43
@macneale4 macneale4 force-pushed the macneale4/archive-clone-fetch branch from 5f8903f to bb3f05e Compare February 12, 2025 21:38
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bb3f05e ok 5937457
version total_tests
bb3f05e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
954f10c ok 5937457
version total_tests
954f10c 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4/archive-clone-fetch branch from 954f10c to 72e7029 Compare February 12, 2025 23:01
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
72e7029 ok 5937457
version total_tests
72e7029 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
dbef286 ok 5937457
version total_tests
dbef286 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4/archive-clone-fetch branch from 541612b to 52fab61 Compare February 13, 2025 17:41
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
52fab61 ok 5937457
version total_tests
52fab61 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
31f1905 ok 5937457
version total_tests
31f1905 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4/archive-clone-fetch branch from 31f1905 to ecac26b Compare February 13, 2025 20:33
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ecac26b ok 5937457
version total_tests
ecac26b 5937457
correctness_percentage
100.0

Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a pass. Generally looks reasonable, some requested changes :).

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b086492 ok 5937457
version total_tests
b086492 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2cab73a ok 5937457
version total_tests
2cab73a 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from reltuk February 14, 2025 01:35
@macneale4
Copy link
Contributor Author

Via discord, reltuk gave the green light

@macneale4 macneale4 merged commit eb91821 into main Feb 14, 2025
21 checks passed
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.57
batching batch sql 10000 1 0.1 1.4
batching by line sql 10000 1 0.09 1.67
blob 1 blob 200000 1 0.99 4.16 4.73
blob 2 blobs 200000 1 0.97 4.86 5.64
blob no blob 200000 1 1.02 2.47 2.77
col type datetime 200000 1 0.84 2.74 3.06
col type varchar 200000 1 0.78 3.78 4.01
config width 2 cols 200000 1 0.89 2.52 2.91
config width 32 cols 200000 1 2.05 2.15 2.49
config width 8 cols 200000 1 1.08 2.45 2.74
pk type float 200000 1 0.93 2.77 2.74
pk type int 200000 1 0.85 2.76 3.04
pk type varchar 200000 1 1.7 2.02 1.91
row count 1.6mm 1600000 1 6.25 3.04 3.06
row count 400k 400000 1 1.64 2.82 3.03
row count 800k 800000 1 3.11 3.01 3.07
secondary index four index 200000 1 4.2 1.33 1.29
secondary index no secondary 200000 1 1.16 2.11 2.41
secondary index one index 200000 1 1.25 2.49 2.72
secondary index two index 200000 1 2.3 1.73 1.73
sorting shuffled 1mm 1000000 0 6.56 2.77 2.72
sorting sorted 1mm 1000000 1 6.52 2.81 2.74

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.25
dolt_blame_commit_filter system table 2.99
dolt_commit_ancestors_commit_filter system table 0.64
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.74
dolt_diff_log_join_to_commit system table 2.68
dolt_diff_table_from_commit_filter system table 1.2
dolt_diff_table_to_commit_filter system table 1.16
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.37
dolt_log_commit_filter system table 1.1

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.1
adds_updates_deletes 60000 60000 60000 4.47
deletes_only 0 60000 0 2.42
updates_only 0 0 60000 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants