Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for dolt_reset('table') in doltgres, plus dolt_constaint_vi… #8376

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Bug fixes for dolt_reset('table') in doltgres, plus dolt_constaint_vi… #8376

merged 2 commits into from
Sep 24, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Sep 23, 2024

…olation table output for same

@zachmu zachmu requested a review from tbantle22 September 23, 2024 23:47
tbantle22
tbantle22 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@tbantle22 tbantle22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
92e02e5 ok 5937457
version total_tests
92e02e5 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e19c58a ok 5937457
version total_tests
e19c58a 5937457
correctness_percentage
100.0

@zachmu zachmu merged commit cf9ea04 into main Sep 24, 2024
20 of 22 checks passed
@tbantle22 tbantle22 deleted the zachmu/reset-2 branch September 24, 2024 19:42
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbantle22 tbantle22 tbantle22 approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @coffeegoddd @tbantle22