Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statspro] Restart drop db #8350

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[statspro] Restart drop db #8350

merged 2 commits into from
Sep 13, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Sep 12, 2024

Quick fix for at least one of the problems in #8345.

The specific example fails because the restart function refreshes the stats database instance, but does not reload the stats contained within. So the contents in memory did not track the contents on disk. This was only noticeable when restart and read were called within the same shell context.

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
205249f ok 5937457
version total_tests
205249f 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
840fe90 ok 5937457
version total_tests
840fe90 5937457
correctness_percentage
100.0

@nicktobey
Copy link
Contributor

Can you add a bit more context in the description? Why was this causing a restart to drop the stats db?

@max-hoffman
Copy link
Contributor Author

Updated comment. We were initializing the stats DB but not the in-memory contents.

@max-hoffman max-hoffman merged commit b42eee3 into main Sep 13, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/restart-drop-db branch September 13, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants