Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kvexec] Fix panic in non-covering strict lookup #8166

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[kvexec] Fix panic in non-covering strict lookup #8166

merged 2 commits into from
Jul 29, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Jul 29, 2024 •
edited
Loading

I missed a test case in nonCovLaxSecondaryLookupGen. I tried to add more tests surrounding the specific panic query here: dolthub/go-mysql-server#2607.

Also rename the rowexec to kvexec.

@max-hoffman max-hoffman requested a review from nicktobey July 29, 2024 18:55
@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7bd6cbd ok 5937457
version total_tests
7bd6cbd 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c149a59 ok 5937457
version total_tests
c149a59 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit c563747 into main Jul 29, 2024
20 of 22 checks passed
@max-hoffman max-hoffman deleted the max/noncov-strict-lookup-panic branch July 29, 2024 19:51
@BrewTestBot BrewTestBot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktobey nicktobey nicktobey approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-hoffman @coffeegoddd @nicktobey