Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tags case insensitive #8153

Merged
merged 5 commits into from
Jul 25, 2024
Merged

make tags case insensitive #8153

merged 5 commits into from
Jul 25, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jul 25, 2024

This PR makes it so tags are case-insensitive.
Additionally, fixes a display error in the sql shell.

fixes #8147

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
221c42b ok 5937457
version total_tests
221c42b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
76e60c6 ok 5937457
version total_tests
76e60c6 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@jycor jycor merged commit eed7e5d into main Jul 25, 2024
21 of 22 checks passed
@jycor jycor deleted the james/tag branch July 25, 2024 23:06
@BrewTestBot BrewTestBot mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag releases: database not found
3 participants
@jycor @coffeegoddd @fulghum