Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive ability to read really old dolt_schema tables #8152

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Revive ability to read really old dolt_schema tables #8152

merged 3 commits into from
Jul 25, 2024

Conversation

macneale4
Copy link
Contributor

We have several old databases which we don't touch but are public on DoltHub. These databases present an error to users with the remove of the migration ability in 1.42.0. The change will bring them back.

@macneale4 macneale4 requested a review from fulghum July 25, 2024 20:16
fulghum
fulghum approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ebfd472 ok 5937457
version total_tests
ebfd472 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 0a07d07 into main Jul 25, 2024
21 checks passed
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9f3acfe ok 5937457
version total_tests
9f3acfe 5937457
correctness_percentage
100.0

@macneale4 macneale4 deleted the macneale4/dolt_schema_revive branch July 25, 2024 21:20
@BrewTestBot BrewTestBot mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @fulghum