Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in dolt sql shell #8150

Merged
merged 15 commits into from
Jul 26, 2024
Merged

fix warnings in dolt sql shell #8150

merged 15 commits into from
Jul 26, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jul 25, 2024

This PR fixes a bug where warnings were incorrectly being suppressed in the dolt sql shell.
The bug is caused by the shell making queries to check if the working set is dirty, what database we're on, and what branch we're on. The fix is to set a special flag in the session to not clear the warnings for those specific queries.

companion pr: dolthub/go-mysql-server#2605

fixes: #8016

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e64da54 ok 5937457
version total_tests
e64da54 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
135cca2 ok 5937457
version total_tests
135cca2 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bc48aac ok 5937457
version total_tests
bc48aac 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3718ade ok 5937457
version total_tests
3718ade 5937457
correctness_percentage
100.0

@jycor jycor merged commit 3e2a7a6 into main Jul 26, 2024
21 checks passed
@jycor jycor deleted the james/session branch July 26, 2024 18:44
@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ff1b430 ok 5937457
version total_tests
ff1b430 5937457
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dolt sql suppresses warnings.
3 participants