Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive DDict cache and multi-file bug fixes #8018

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Archive DDict cache and multi-file bug fixes #8018

merged 9 commits into from
Jun 14, 2024

Conversation

macneale4
Copy link
Contributor

Two primary issues addressed in the dolt admin archive command:

  1. Add caching to dictionaries. This improved performance significantly.
  2. Fix multiple bugs related to having multiple table files. That was a gap in testing, so added a bats test for the command.

@macneale4 macneale4 requested a review from fulghum June 13, 2024 17:21
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
297d756 ok 5937457
version total_tests
297d756 5937457
correctness_percentage
100.0

@macneale4 macneale4 marked this pull request as draft June 13, 2024 17:53
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
20eb7a8 ok 5937457
version total_tests
20eb7a8 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0714624 ok 5937457
version total_tests
0714624 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
25f6de0 ok 5937457
version total_tests
25f6de0 5937457
correctness_percentage
100.0

@macneale4 macneale4 marked this pull request as ready for review June 13, 2024 21:29
fulghum
fulghum approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
09f1835 ok 5937457
version total_tests
09f1835 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 14a4af5 into main Jun 14, 2024
21 checks passed
@macneale4 macneale4 deleted the macneale4/archive-multi-file-bug branch June 14, 2024 00:45
@BrewTestBot BrewTestBot mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @fulghum