Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WritableDoltTable.UpdateForeignKey() to update FK name #7968

Closed
wants to merge 2 commits into from

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jun 6, 2024

dolthub/go-mysql-server#2536 changes RENAME TABLE to rename auto-generated foreign keys, and requires implementations of UpdateForeignKey() to honor the new name passed in for the foreign key.

Related to #7959

Copy link

github-actions bot commented Jun 6, 2024

Additional work is required for integration with DoltgreSQL.

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e191ce8 ok 5937457
version total_tests
e191ce8 5937457
correctness_percentage
100.0

@fulghum
Copy link
Contributor Author

fulghum commented Jun 6, 2024

Closing out this PR, since I cherry-picked commit b771a88 from this PR directly to the auto-bump PR with the associated GMS change: #7969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants