Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing database init/drop hooks to be a slice of hooks #7804

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented May 1, 2024

The Dolt database provider currently has a single init hook and a single drop hook. We have a few hooks, and in order to support multiple hooks, we chain them together. Binlog replication will also need to register a similar init and drop hook to capture database create/drop actions, so to prepare for that, this PR turns the single init hook and single drop hook into a slice of init hooks and a slice of drop hooks.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7e651ef ok 5937457
version total_tests
7e651ef 5937457
correctness_percentage
100.0

…ntext) for consistency with InitDatabaseHook
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6056d23 ok 5937457
version total_tests
6056d23 5937457
correctness_percentage
100.0

@fulghum fulghum marked this pull request as ready for review May 1, 2024 21:38
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no notes

@fulghum fulghum merged commit 76da4e5 into main May 2, 2024
20 checks passed
@fulghum fulghum deleted the fulghum/hooks branch May 2, 2024 00:10
Copy link

github-actions bot commented May 2, 2024

@max-hoffman DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.17
batching batch sql 10000 1 0.07 2
batching by line sql 10000 1 0.07 2
blob 1 blob 200000 1 0.93 3.97 4.31
blob 2 blobs 200000 1 0.9 4.91 5.28
blob no blob 200000 1 0.91 2.07 2.13
col type datetime 200000 1 0.82 2.6 2.8
col type varchar 200000 1 0.69 2.93 2.96
config width 2 cols 200000 1 0.76 2.5 2.34
config width 32 cols 200000 1 1.82 1.81 2.58
config width 8 cols 200000 1 0.99 1.99 2.78
pk type float 200000 1 0.9 1.84 1.97
pk type int 200000 1 0.86 1.95 2.12
pk type varchar 200000 1 1.65 1.35 1.38
row count 1.6mm 1600000 1 5.61 2.49 2.61
row count 400k 400000 1 1.41 2.43 2.55
row count 800k 800000 1 2.9 2.39 2.52
secondary index four index 200000 1 3.65 1.27 1.08
secondary index no secondary 200000 1 0.91 2.07 2.15
secondary index one index 200000 1 1.15 2.08 2.16
secondary index two index 200000 1 2.01 1.54 1.44
sorting shuffled 1mm 1000000 0 5.59 2.34 2.39
sorting sorted 1mm 1000000 1 5.39 2.4 2.46

Copy link

github-actions bot commented May 2, 2024

@max-hoffman DOLT

name detail mean_mult
dolt_blame_basic system table 1.24
dolt_blame_commit_filter system table 3.26
dolt_commit_ancestors_commit_filter system table 0.84
dolt_commits_commit_filter system table 0.91
dolt_diff_log_join_from_commit system table 2.13
dolt_diff_log_join_to_commit system table 2.12
dolt_diff_table_from_commit_filter system table 1.1
dolt_diff_table_to_commit_filter system table 1.1
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.17
dolt_log_commit_filter system table 0.94

Copy link

github-actions bot commented May 2, 2024

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.17
batching batch sql 10000 1 0.08 1.75
batching by line sql 10000 1 0.08 1.75
blob 1 blob 200000 1 0.88 4.17 4.65
blob 2 blobs 200000 1 0.88 5.09 5.76
blob no blob 200000 1 0.89 2.11 2.22
col type datetime 200000 1 0.8 2.75 2.91
col type varchar 200000 1 0.67 3.12 3.31
config width 2 cols 200000 1 0.77 2.21 2.35
config width 32 cols 200000 1 1.87 1.81 2.56
config width 8 cols 200000 1 0.97 2.05 2.34
pk type float 200000 1 0.86 2 2.12
pk type int 200000 1 0.79 2.49 2.25
pk type varchar 200000 1 1.51 1.5 1.67
row count 1.6mm 1600000 1 5.57 2.54 2.68
row count 400k 400000 1 1.41 2.43 2.62
row count 800k 800000 1 2.8 2.48 2.65
secondary index four index 200000 1 3.6 1.28 1.12
secondary index no secondary 200000 1 0.92 2.03 2.21
secondary index one index 200000 1 1.15 2.11 2.2
secondary index two index 200000 1 2.02 1.55 1.55
sorting shuffled 1mm 1000000 0 5.17 2.54 2.64
sorting sorted 1mm 1000000 1 5.26 2.49 2.59

Copy link

github-actions bot commented May 2, 2024

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.24
dolt_blame_commit_filter system table 3.23
dolt_commit_ancestors_commit_filter system table 0.86
dolt_commits_commit_filter system table 0.91
dolt_diff_log_join_from_commit system table 2.05
dolt_diff_log_join_to_commit system table 2.07
dolt_diff_table_from_commit_filter system table 1.1
dolt_diff_table_to_commit_filter system table 1.12
dolt_diffs_commit_filter system table 0.97
dolt_history_commit_filter system table 1.17
dolt_log_commit_filter system table 0.94

Copy link

github-actions bot commented May 2, 2024

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.71
adds_updates_deletes 60000 60000 60000 3.76
deletes_only 0 60000 0 1.87
updates_only 0 0 60000 2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants