Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] simplified warn on error behavior #7379

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 20, 2024

Previous behavior had many places where it checked the warn on error setting, but only one is actually necessary (StartTransaction). We should probably get rid of that setting altogether soon.

Also added a test that tag deletions are properly replicated.

@zachmu zachmu requested a review from max-hoffman January 20, 2024 01:36
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming we have some duplicate mechanism catching the warnings, idk what relation the bats test has to these changes also

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
99.997743 to 99.997743
version result total
f5df985 not ok 134
f5df985 ok 5937323
version total_tests
f5df985 5937457
correctness_percentage
99.997743

@zachmu zachmu merged commit dee5e41 into main Jan 20, 2024
21 of 22 checks passed
@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
99.997743 to 99.997743
version result total
da1bb8d not ok 134
da1bb8d ok 5937323
version total_tests
da1bb8d 5937457
correctness_percentage
99.997743

Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 0.8
batching batch sql 10000 1 0.07 1.57
batching by line sql 10000 1 0.08 1.25
blob 1 blob 200000 1 0.89 3.11 3.56
blob 2 blobs 200000 1 0.87 4.06 4.69
blob no blob 200000 1 0.87 1.32 1.4
col type datetime 200000 1 0.79 1.8 2.29
col type varchar 200000 1 0.66 2.02 2.02
config width 2 cols 200000 1 0.75 1.29 1.45
config width 32 cols 200000 1 1.87 1.38 2.45
config width 8 cols 200000 1 0.97 1.93 1.64
pk type float 200000 1 0.86 1.19 1.26
pk type int 200000 1 0.77 1.26 1.32
pk type varchar 200000 1 1.51 0.98 0.98
row count 1.6mm 1600000 1 5.42 1.54 1.6
row count 400k 400000 1 1.41 1.43 1.5
row count 800k 800000 1 2.78 1.48 1.53
secondary index four index 200000 1 3.49 1.11 0.95
secondary index no secondary 200000 1 0.86 1.31 1.47
secondary index one index 200000 1 1.11 1.48 1.49
secondary index two index 200000 1 1.97 1.21 1.11
sorting shuffled 1mm 1000000 0 4.91 1.9 1.87
sorting sorted 1mm 1000000 1 4.97 1.87 1.85

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.02
dolt_blame_commit_filter system table 2.64
dolt_commit_ancestors_commit_filter system table 0.87
dolt_commits_commit_filter system table 0.9
dolt_diff_log_join_from_commit system table 1.64
dolt_diff_log_join_to_commit system table 1.65
dolt_diff_table_from_commit_filter system table 1.06
dolt_diff_table_to_commit_filter system table 1.08
dolt_diffs_commit_filter system table 0.97
dolt_history_commit_filter system table 1.39
dolt_log_commit_filter system table 0.84

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.71
adds_updates_deletes 60000 60000 60000 3.71
deletes_only 0 60000 0 1.84
updates_only 0 0 60000 2.33

@Hydrocharged Hydrocharged deleted the zachmu/replicate-tags branch February 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants