Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inf loop for creds search on windows #7094

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix inf loop for creds search on windows #7094

merged 1 commit into from
Dec 4, 2023

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Dec 4, 2023

There was an infinite loop for dolt init and dolt sql when there isn't a .dolt directory in current directory or any children directory. This issue was specific to windows, because we were only checking for / and not \.

@jycor jycor changed the title [no-release-notes] fix inf loop for creds on windows [no-release-notes] fix inf loop for creds search on windows Dec 4, 2023
@timsehn
Copy link
Contributor

timsehn commented Dec 4, 2023

Why no release notes?

Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor changed the title [no-release-notes] fix inf loop for creds search on windows fix inf loop for creds search on windows Dec 4, 2023
@jycor jycor merged commit e8ce41f into main Dec 4, 2023
@Hydrocharged Hydrocharged deleted the james/hang branch February 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants