Added a periodic heartbeat event metric to sql-server
#7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this manually, a little tricky to test via bats but open to suggestions |
… case of a bad GRPC client
reltuk
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Looks great.
One comment would be that it seems Application, as a mutable global variable in the event emitter or construction package or whatever, should be commented, so that it's clear that doltgres as a separate entry point is going to set it, and it should be set once at the beginning of a program, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds new constants for Doltgres as an application