Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt modify #6237

Merged
merged 1 commit into from
Jun 27, 2023
Merged

chore: fmt modify #6237

merged 1 commit into from
Jun 27, 2023

Conversation

testwill
Copy link
Contributor

unnecessary use of fmt.Sprintf
use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...))
use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (but don't forget the newline)

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @testwill! 🙏

These changes all look great. Thank you for helping tidy up our codebase! I'll go ahead and merge these fixes in after the CI checks run.

@fulghum fulghum merged commit 167f778 into dolthub:main Jun 27, 2023
@fulghum
Copy link
Contributor

fulghum commented Jun 27, 2023

Merged to main! 🎉 Thanks again for the great contribution @testwill! Feel free to drop by the DoltHub Discord if you ever wanna chat with us about Dolt, Golang, or databases! 🤓

@testwill
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants