Report auto increment changes in dolt diff and dolt_diff_summary()
#8910
+129
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #8907
Previously, diffs would only look at the schema hash when determining whether or not a table had a schema change. However, the auto increment counter, which is considered part of the schema, is not stored in the schema flatbuffer and thus does not affect the schema hash.
This led to situations where a diff would detect that a table had changed (because the table hash changed), but it reported neither a data change or a schema change (because the data hash and schema hash were the same.) This was confusing.
Now,
dolt_diff_summary
will correctly report a schema change when the auto increment counter has changed, anddolt diff
will show the autoincrement value in theSHOW CREATE TABLE
output.