Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bindgen for dojo.js sdk #2501

Merged
merged 10 commits into from
Oct 18, 2024

Merge remote-tracking branch 'dojo/main' into feat/dojojs-sdk-codegen

688bc7d
Select commit
Loading
Failed to load commit list.
Merged

feat: update bindgen for dojo.js sdk #2501

Merge remote-tracking branch 'dojo/main' into feat/dojojs-sdk-codegen
688bc7d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

69.79% (+0.27%) compared to 90a6580

View this Pull Request on Codecov

69.79% (+0.27%) compared to 90a6580

Details

Codecov Report

Attention: Patch coverage is 69.06112% with 491 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (90a6580) to head (688bc7d).

Files with missing lines Patch % Lines
crates/dojo-bindgen/src/plugins/recs/mod.rs 35.51% 325 Missing ⚠️
...ates/dojo-bindgen/src/plugins/typescript/writer.rs 33.92% 74 Missing ⚠️
...jo-bindgen/src/plugins/typescript/generator/erc.rs 0.00% 33 Missing ⚠️
crates/dojo-bindgen/src/plugins/typescript/mod.rs 0.00% 33 Missing ⚠️
...jo-bindgen/src/plugins/typescript/generator/mod.rs 92.65% 18 Missing ⚠️
...ndgen/src/plugins/typescript/generator/function.rs 98.31% 4 Missing ⚠️
...bindgen/src/plugins/typescript/generator/schema.rs 98.88% 2 Missing ⚠️
crates/dojo-bindgen/src/lib.rs 0.00% 1 Missing ⚠️
crates/dojo-bindgen/src/plugins/mod.rs 96.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   69.51%   69.79%   +0.27%     
==========================================
  Files         388      396       +8     
  Lines       50076    51160    +1084     
==========================================
+ Hits        34811    35707     +896     
- Misses      15265    15453     +188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov