Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bindgen for dojo.js sdk #2501

Merged
merged 10 commits into from
Oct 18, 2024

refac: use specific type alias to avoid duplication

cf57537
Select commit
Loading
Failed to load commit list.
Merged

feat: update bindgen for dojo.js sdk #2501

refac: use specific type alias to avoid duplication
cf57537
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 15, 2024 in 1s

68.90% (+0.25%) compared to 9f95a68

View this Pull Request on Codecov

68.90% (+0.25%) compared to 9f95a68

Details

Codecov Report

Attention: Patch coverage is 69.30826% with 457 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (9f95a68) to head (cf57537).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
crates/dojo-bindgen/src/plugins/recs/mod.rs 35.51% 325 Missing ⚠️
...ates/dojo-bindgen/src/plugins/typescript/writer.rs 34.51% 74 Missing ⚠️
crates/dojo-bindgen/src/plugins/typescript/mod.rs 0.00% 32 Missing ⚠️
...jo-bindgen/src/plugins/typescript/generator/mod.rs 91.37% 15 Missing ⚠️
...bindgen/src/plugins/typescript/generator/schema.rs 97.48% 5 Missing ⚠️
...ndgen/src/plugins/typescript/generator/function.rs 98.31% 4 Missing ⚠️
crates/dojo-bindgen/src/lib.rs 0.00% 1 Missing ⚠️
crates/dojo-bindgen/src/plugins/mod.rs 96.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   68.64%   68.90%   +0.25%     
==========================================
  Files         372      394      +22     
  Lines       48441    50974    +2533     
==========================================
+ Hits        33251    35122    +1871     
- Misses      15190    15852     +662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov