This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Fix bug, add tests, update i18n version #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
force-pushed
the
fix-selection-utilities
branch
from
25af28c to
90c37fc
Compare
agubler
reviewed
Nov 15, 2017
src/support/d.ts
Outdated
| @@ -133,7 +133,7 @@ function findByKey( | |||
| target.children | |||
| .forEach((child, index) => { | |||
| if (isNode(child)) { | |||
| if (found) { | |||
| if (found && found.found) { | |||
There was a problem hiding this comment.
do you think we could name found better? like perhaps nodeInfo?
There was a problem hiding this comment.
Yes that makes more sense. Updated
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 9 9
Lines 618 618
Branches 173 173
=======================================
Hits 612 612
Partials 6 6
Continue to review full report at Codecov.
|
agubler
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
This was not properly checking the return value of recursive calls.