This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Remove error reporter and intern dep #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 98.56% 98.46% -0.11%
==========================================
Files 10 9 -1
Lines 626 585 -41
Branches 163 158 -5
==========================================
- Hits 617 576 -41
Misses 1 1
Partials 8 8
Continue to review full report at Codecov.
|
maier49
force-pushed
the
remove-error-reporter-and-intern-dep
branch
from
7800c9d to
b9dfea7
Compare
|
The decrease in coverage is just because the remaining files have lower coverage than what's being removed. I tried to add some tests to cover some missing branches but apparently they were already covered in browsers I wasn't testing with. |
kitsonk
approved these changes
Nov 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Removes the
ClientErrorCollectorand makesInternadevDependencyinstead of apeerDependencyResolves #79