This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Update for latest widget core #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
commented
Sep 20, 2017
| @@ -63,5 +63,6 @@ export default function callListener(node: HNode | WNode, method: string, option | |||
| if (!listener) { | |||
| throw new TypeError(`Cannot resolve listener: "${method}"`); | |||
| } | |||
| listener.apply(thisArg || resolvedTarget.properties.bind, args); | |||
| const bind = resolvedTarget.coreProperties ? resolvedTarget.coreProperties.bind : resolvedTarget.properties.bind; | |||
There was a problem hiding this comment.
bind is now on coreProperties for a WNode and properties for a HNode
agubler
commented
Sep 20, 2017
| @@ -269,7 +278,8 @@ export class Harness<P extends WidgetProperties, W extends Constructor<WidgetBas | |||
| this._projectionRoot = projectionRoot; | |||
| this._projectionOptions = { | |||
| transitions: cssTransitions, | |||
| eventHandlerInterceptor: this._eventHandlerInterceptor.bind(this._widgetHarness) | |||
| eventHandlerInterceptor: this._eventHandlerInterceptor.bind(this._widgetHarness), | |||
| nodeEvent: new Evented() | |||
There was a problem hiding this comment.
A new projector options added for meta
agubler
commented
Sep 20, 2017
src/support/assertRender.ts
Outdated
| @@ -37,7 +37,7 @@ function throwAssertionError(actual: any, expected: any, message?: string): neve | |||
| */ | |||
| const defaultDiffOptions: DiffOptions = { | |||
| allowFunctionValues: true, | |||
| ignoreProperties: [ 'bind', 'defaultRegistry' ] | |||
| ignoreProperties: [ 'bind', 'afterCreate', 'afterUpdate' ] | |||
There was a problem hiding this comment.
Need to look at why these are being added when they weren't expected before the update.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 98.26% 98.27% +<.01%
==========================================
Files 10 10
Lines 692 696 +4
Branches 162 163 +1
==========================================
+ Hits 680 684 +4
Misses 4 4
Partials 8 8
Continue to review full report at Codecov.
|
agubler
force-pushed
the
update-for-widget-core-changes
branch
from
bb86a5d to
a77f412
Compare
kitsonk
approved these changes
Sep 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Updates for latest widget core changes.
Depends on widget-core release