Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Add better default error message for mismatched strings #57

Merged
merged 2 commits into from
Jul 1, 2017

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Jun 30, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
This adds a default message for when assertRender fails comparing strings. In contrast to the error in #56, this is the error for the same failure with this change.

AssertionError: Render unexpected: Expected "foo" to equal "bar"
  at <_build\src\support\assertRender.js:141:17>
  at Array.forEach  <native>
  at assertChildren  <_build\src\support\assertRender.js:138:20>
  at Object.assertRender [as default]  <_build\src\support\assertRender.js:202:21>
  at Test.string children unequal [as test]  <tests\unit\support\assertRender.ts:126:5>
  at <node_modules\intern\lib\Test.js:191:24>
  at <node_modules\intern\browser_modules\dojo\Promise.ts:393:15>
  at runCallbacks  <node_modules\intern\browser_modules\dojo\Promise.ts:11:11>
  at <node_modules\intern\browser_modules\dojo\Promise.ts:317:4>
  at run  <node_modules\intern\browser_modules\dojo\Promise.ts:237:7>

Resolves #56

@maier49 maier49 requested a review from kitsonk June 30, 2017 23:40
@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          10       10           
  Lines         692      692           
  Branches      161      162    +1     
=======================================
  Hits          680      680           
  Misses          4        4           
  Partials        8        8
Impacted Files Coverage Δ
src/support/assertRender.ts 97.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d9253...f1ea5f5. Read the comment docs.

@maier49 maier49 merged commit 52b3807 into dojo:master Jul 1, 2017
@maier49 maier49 deleted the better-error-message-for-strings branch July 1, 2017 17:40
@dylans dylans added this to the 2017.06 milestone Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants