This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Remove bind references and and call _render explicitly #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
========================================
- Coverage 98.5% 98.2% -0.3%
========================================
Files 10 10
Lines 669 670 +1
Branches 158 158
========================================
- Hits 659 658 -1
Misses 4 4
- Partials 6 8 +2
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
May 16, 2017
kitsonk
approved these changes
May 17, 2017
agubler
changed the title
agubler
force-pushed
the
widget-core-upgrade
branch
from
7d4505c to
0b48447
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Upgrade to support changes in widget-core. 1) removal of
bindproperty 2) change to invalidating during the properties change lifecycle.Needs release of widget-core.