Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Allow target to be mocked in sendEvent #13

Closed
wants to merge 2 commits into from
Closed

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Apr 12, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This PR adds the ability to supply target as part of the eventInit of sendEvent for use cases where there is a need for a mock of the target when dispatching an event on the real target.

Resolves #12

@kitsonk kitsonk requested a review from agubler April 12, 2017 16:43
@codecov
Copy link

codecov bot commented Apr 12, 2017

Codecov Report

Merging #13 into master will decrease coverage by 1.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
- Coverage   98.57%   96.97%   -1.6%     
=========================================
  Files           8        8             
  Lines         560      562      +2     
  Branches      126      127      +1     
=========================================
- Hits          552      545      -7     
- Misses          4        9      +5     
- Partials        4        8      +4
Impacted Files Coverage Δ
src/support/sendEvent.ts 100% <100%> (ø) ⬆️
src/support/assertRender.ts 91.42% <0%> (-8.58%) ⬇️
src/harness.ts 95.5% <0%> (-3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc219c...8ddbbfb. Read the comment docs.

@dylans dylans added this to the 2017.04 milestone Apr 12, 2017
@kitsonk
Copy link
Member Author

kitsonk commented Apr 24, 2017

Right now, the use case that was driving this has gone away, so it doesn't make sense to address this until we have a valid use case. Closing for now.

@kitsonk kitsonk closed this Apr 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants