This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Replacing noEmitHelpers with importHelpers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
noEmitHelperswithimportHelpers. We need this for compatibility with webpack. Including the patch to tslib to update__valuesfor string iteration.We still want to load
@dojo/shim/mainfirst as it is going to load all the required polyfills. The only real downstream change here is that we'll be settingimportHelpers: trueinstead ofnoEmitHelpers: true.When this has landed, I'll merge / update
core, then we can get to widget-core.