This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Typescript 2.6 #118
Merged
Typescript 2.6 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
force-pushed
the
typescript-2.6
branch
3 times, most recently
from
535f575 to
9cd2617
Compare
bryanforbes
force-pushed
the
typescript-2.6
branch
from
9cd2617 to
79a53b2
Compare
agubler
reviewed
Nov 27, 2017
src/Symbol.ts
Outdated
| @@ -24,7 +24,7 @@ if (!has('es6-symbol')) { | |||
| }; | |||
|
|
|||
| const defineProperties = Object.defineProperties; | |||
| const defineProperty: (o: any, p: string | symbol, attributes: PropertyDescriptor & ThisType<any>) => any = Object.defineProperty; | |||
| const defineProperty: (o: any, p: string | symbol, attributes: PropertyDescriptor & ThisType<any>) => any = <any> Object.defineProperty; | |||
src/support/has.ts
Outdated
| @@ -132,7 +132,9 @@ add('es6-string', () => { | |||
|
|
|||
| add('es6-string-raw', () => { | |||
| function getCallSite(callSite: TemplateStringsArray, ...substitutions: any[]) { | |||
| return callSite; | |||
| const result = [...callSite]; | |||
There was a problem hiding this comment.
nit: code style: [ ...callSite ]
src/support/has.ts
Outdated
| @@ -132,7 +132,9 @@ add('es6-string', () => { | |||
|
|
|||
| add('es6-string-raw', () => { | |||
| function getCallSite(callSite: TemplateStringsArray, ...substitutions: any[]) { | |||
| return callSite; | |||
| const result = [...callSite]; | |||
| (<any> result).raw = callSite.raw; | |||
| @@ -22,8 +22,13 @@ export function getValueDescriptor<T>(value: T, enumerable: boolean = false, wri | |||
| * | |||
| * @param nativeFunction The source function to be wrapped | |||
| */ | |||
| export function wrapNative<T, U, R>(nativeFunction: (...args: U[]) => R): (target: T, ...args: U[]) => R { | |||
| return function (target: T, ...args: U[]): R { | |||
| export function wrapNative<T, U, R>(nativeFunction: (arg1: U) => R): (target: T, arg1: U) => R; | |||
There was a problem hiding this comment.
Is this a change required for the TS2.6 upgrade?
There was a problem hiding this comment.
Yes. If the old signature is left as-is, 10 errors occur. As an example, in src/array.ts the following error occurs:
src/array.ts(125,2): error TS2322: Type '(target: ArrayLike<T>, ...args: number[]) => ArrayLike<T>' is not assignable to type '<T>(target: ArrayLike<T>, offset: number, start: number, end?: number | undefined) => ArrayLike<T>'.
Types of parameters 'args' and 'end' are incompatible.
Type 'number | undefined' is not assignable to type 'number'.
Type 'undefined' is not assignable to type 'number'.
tomdye
approved these changes
Nov 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: enhancement
The following has been addressed in the PR:
Description:
Relates to dojo/meta#210