Converting to intern4 #110
Conversation
package.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| "@types/node": "~6.0.49", | |||
| "grunt": "~1.0.1", | |||
| "grunt-dojo2": "latest", | |||
| "intern": "^3.4.1", | |||
| "intern": "next", | |||
There was a problem hiding this comment.
I'd recommend using a specific version as the API in 'next' may change.
There was a problem hiding this comment.
I pinned this to 4.0.0-alpha.13
| @@ -0,0 +1,14 @@ | |||
| export * from './intern'; | |||
There was a problem hiding this comment.
Note that Intern no longer uses JS modules for config. The configuration is now a JSON file.
There was a problem hiding this comment.
These files are turned into JSON using a convoluted process in grunt-dojo2, you can see that here: dojo/grunt-dojo2#146
There was a problem hiding this comment.
Ah, I wondered if that might be case. Unfortunate that it means you can't run the tests without grunt-dojo2, though.
There was a problem hiding this comment.
Well the reason I left them as js files was because we load them and extend them. If that is not a pattern we should be using w/ intern4, what's the way we should be doing that? Is it ideal to just have the different json files that we keep in sync?
There was a problem hiding this comment.
A config file can extend another, similar to how tsconfig.json files work.
tests/unit/Map.ts
Outdated
| @@ -57,7 +56,7 @@ registerSuite({ | |||
| }, | |||
|
|
|||
| 'delete': { | |||
| before() { | |||
| before(this: any) { | |||
There was a problem hiding this comment.
You shouldn't need to provide a type for this in a test (and this method doesn't even appear to use this).
tests/functional/asyncAwait.ts
Outdated
| import pollUntil = require('intern/dojo/node!leadfoot/helpers/pollUntil'); | ||
|
|
||
| registerSuite({ | ||
| registerSuite('asyncAwait', { | ||
| 'Async/Await with Bluebird'(this: any) { |
There was a problem hiding this comment.
You shouldn't need the explicit this here.
|
ci failures are from the docs.. |
Type: feature
The following has been addressed in the PR:
Description:
Updating to work with intern 4. Depends on dojo/grunt-dojo2#146.