Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch distribution errors early #200

Closed
6 of 23 tasks
kitsonk opened this issue Sep 2, 2017 · 1 comment
Closed
6 of 23 tasks

Catch distribution errors early #200

kitsonk opened this issue Sep 2, 2017 · 1 comment
Labels
beta4 beta5 enhancement
Milestone
beta.5

Comments

@kitsonk
Copy link
Member

kitsonk commented Sep 2, 2017 •
edited
Loading

Feature

We have had several issues the visibility of types when trying to create a distribution, where certain types are not being exported and therefore make it impossible to generate declaration files. In order to try to address this we should:

  • ensure that grunt:dist is run for each repo
  • default to --declaration even on our development builds

The repos:
@kitsonk kitsonk added this to the 2017.09 milestone Sep 2, 2017
This was referenced Sep 2, 2017
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dylans dylans modified the milestones: 2017.09, 2017.10 Sep 26, 2017
@kitsonk kitsonk added beta4 and removed beta3 labels Oct 9, 2017
kitsonk added a commit to dojo/shim that referenced this issue Oct 10, 2017
@kitsonk
Add dist to CI and default to declaration true (#112)
94e097b 
Refs: dojo/meta#200
@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@kitsonk kitsonk added beta5 and removed beta4 labels Nov 29, 2017
@kitsonk kitsonk modified the milestones: beta.4, beta.5 Nov 29, 2017
@kitsonk kitsonk added the beta4 label Dec 1, 2017
kitsonk added a commit to dojo/has that referenced this issue Dec 5, 2017
@kitsonk
Change declaration to true in tsconfig (#55)
9815a13 
References: dojo/meta#200
kitsonk added a commit to dojo/core that referenced this issue Dec 5, 2017
@kitsonk
Update CI and tsconfig to detect dist errors early (#354)
a345bb6 
References: dojo/meta#200
@kitsonk
Copy link
Member Author

kitsonk commented Dec 11, 2017

This all appear to be merged now...

@kitsonk kitsonk closed this as completed Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta4 beta5 enhancement
Projects
None yet
Milestone
beta.5
Development

No branches or pull requests
2 participants
@dylans @kitsonk