Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

Remove global and use @dojo/shim/global #303

Closed
wants to merge 2 commits into from
Closed

Remove global and use @dojo/shim/global #303

wants to merge 2 commits into from

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Mar 8, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Removes global from core and uses @dojo/shim/global instead.

Resolves #302

@kitsonk
Copy link
Member Author

kitsonk commented Mar 8, 2017

Requires dojo/shim#80 to land first.

@dylans dylans added this to the 2017.03 milestone Mar 8, 2017
@kitsonk
Copy link
Member Author

kitsonk commented Mar 8, 2017

Let's re-export @dojo/shim/global for now to cause the least amount of downstream breakage.

@codecov-io
Copy link

Codecov Report

Merging #303 into master will decrease coverage by -86.9%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #303      +/-   ##
=========================================
- Coverage   93.86%   6.96%   -86.9%     
=========================================
  Files          38      37       -1     
  Lines        2135    2124      -11     
  Branches      405     402       -3     
=========================================
- Hits         2004     148    -1856     
- Misses         52    1976    +1924     
+ Partials       79       0      -79
Impacted Files Coverage Δ
src/main.ts 0% <ø> (-100%)
src/request/providers/xhr.ts 3.54% <0%> (-82.27%)
src/has.ts 0% <0%> (-100%)
src/queue.ts 0% <0%> (-100%)
src/MultiMap.ts 1.07% <0%> (-98.93%)
src/DateObject.ts 1.39% <0%> (-98.61%)
src/IdentityRegistry.ts 3.17% <0%> (-96.83%)
src/request.ts 0% <0%> (-96.16%)
src/encoding.ts 0.67% <0%> (-95.98%)
src/Observable.ts 3.84% <0%> (-94.88%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f3b35...6bc588c. Read the comment docs.

@dylans dylans modified the milestones: 2017.03, 2017.04 Apr 2, 2017
@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@dylans
Copy link
Member

dylans commented May 19, 2017

This one is now stale and needs a rebase @kitsonk

@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans added this to the 2017.07 milestone Jun 12, 2017
@kitsonk
Copy link
Member Author

kitsonk commented Jun 28, 2017

Replaced with a different PR

@kitsonk kitsonk closed this Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants