fix: panic on using WaitGroup after it is freed (#1464) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bnb-chain#1379 try to fix the random UT fail of TestLargeReorgTrieGC, while it introduced another bug.
It could cause panic crash, since
wgcould be used after it is freed, since there is an asynchronous risk.For detail of the panic, you may refer: bnb-chain#1456
Rationale
To fix the UT fail, we only need to make sure
triedb.Dereference(root.(common.Hash))can be done intryCommitTrieDB(), so we can just add anotherWaitGroupintryCommitTrieDB()for synchronization.