Merge pull request #789 from dodona-edu/dependabot/npm_and_yarn/eslin…

…t-be7977c65c

Bump the eslint group across 1 directory with 2 updates

eslint.config.mjs

@@ -0,0 +1,49 @@
+import tseslint from "typescript-eslint";
+import eslint from "@eslint/js";
+
+export default tseslint.config(
+    {
+        ignores: [
+            "**/webpack.config.js",
+            "**/tailwind.config.js",
+            "**/postcss.config.js",
+            "**/jest.config.js",
+            "src/Translations.js",
+            "scripts/ValidateTranslations.js",
+            "**/dist",
+        ],
+    },
+    eslint.configs.recommended,
+    {
+        rules: {
+            "arrow-parens": ["error", "as-needed"],
+            "comma-dangle": ["error", {
+                arrays: "only-multiline",
+                objects: "only-multiline",
+                imports: "only-multiline",
+                exports: "only-multiline",
+                functions: "never",
+            }],
+            indent: ["error", 4, { SwitchCase: 1 }],
+            "no-invalid-this": "warn",
+            "no-param-reassign": ["error", { props: false }],
+            "object-curly-spacing": ["error", "always"],
+            quotes: ["error", "double"],
+            "space-before-function-paren": ["error", {
+                anonymous: "always",
+                named: "never",
+                asyncArrow: "always",
+            }],
+        },
+    },
+    tseslint.configs.recommended,
+    {
+        rules: {
+            "@typescript-eslint/explicit-member-accessibility": "off",
+            "@typescript-eslint/explicit-function-return-type": ["error", { allowExpressions: true }],
+            "@typescript-eslint/no-parameter-properties": "off",
+            "@typescript-eslint/no-explicit-any": "off",
+            "@typescript-eslint/no-non-null-assertion": "off",
+        },
+    }
+);

package.json

@@ -4,17 +4,16 @@
   "private": false,
   "homepage": ".",
   "devDependencies": {
+    "@eslint/eslintrc": "^3.2.0",
+    "@eslint/js": "^9.18.0",
     "@types/escape-html": "^1.0.3",
     "@types/i18n-js": "^3.8.9",
     "@types/jest": "^29.5.10",
     "@types/serviceworker": "^0.0.89",
-    "@typescript-eslint/eslint-plugin": "^7.0.1",
-    "@typescript-eslint/parser": "^7.0.1",
     "autoprefixer": "^10.4.16",
     "css-loader": "^7.1.2",
-    "eslint": "^8.52.0",
-    "eslint-config-google": "^0.14.0",
-    "eslint-plugin-jest": "^27.6.0",
+    "eslint": "^9.17.0",
+    "globals": "^15.14.0",
     "i18n-extract": "^0.6.7",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
@@ -28,6 +27,7 @@
     "ts-jest-mock-import-meta": "^1.1.0",
     "ts-loader": "^9.5.0",
     "typescript": "^5.2.2",
+    "typescript-eslint": "^8.21.0",
     "webpack": "^5.89.0",
     "webpack-cli": "^6.0.1",
     "webpack-dev-server": "^5.0.2",
@@ -62,7 +62,7 @@
     "build:app": "bash scripts/build.sh development",
     "build:library": "bash scripts/build_library.sh",
     "test": "jest",
-    "lint": "eslint  --ext '.js' --ext '.ts' src",
+    "lint": "eslint src",
     "validate:translations": "node scripts/ValidateTranslations.js"
   },
   "description": "Scratchpad for multiple programming languages in the browser.",

src/CodeRunner.ts

@@ -472,7 +472,7 @@ export class CodeRunner extends Renderable<CodeRunnerRenderOptions> {
 
     protected override _render(options: CodeRunnerRenderOptions): HTMLElement {
         appendClasses(options.statusPanelOptions,
-            // eslint-disable-next-line max-len
+             
             "_tw-border-solid _tw-border-gray-200 _tw-border-b-2 dark:_tw-border-dark-mode-content");
         const rendered = renderWithOptions(options.statusPanelOptions, `
 <div style="position: relative">

src/OutputManager.ts

@@ -184,7 +184,7 @@ export class OutputManager extends Renderable {
             }
             errorHTML += "<div class=\"_tw-text-red-500 _tw-text-bold\">";
             const infoQM = renderInCircle("?", escapeHTML(errorObject.info),
-                // eslint-disable-next-line max-len
+                 
                 "_tw-text-blue-500 _tw-border-blue-500 dark:_tw-text-dark-mode-blue dark:_tw-border-dark-mode-blue");
             const tracebackEM = renderInCircle("!",
                 escapeHTML(errorObject.traceback), "_tw-text-red-500 _tw-border-red-500");

src/Papyros.ts

@@ -1,4 +1,4 @@
-/* eslint-disable max-len */
+ 
 import {
     DARK_MODE_TOGGLE_ID,
     EDITOR_WRAPPER_ID,
@@ -145,7 +145,7 @@ export class Papyros extends Renderable<PapyrosRenderOptions> {
         } else {
             try {
                 await this.codeRunner.start();
-            } catch (error: any) {
+            } catch {
                 if (confirm(t("Papyros.launch_error"))) {
                     return this.launch();
                 }
@@ -217,7 +217,7 @@ export class Papyros extends Renderable<PapyrosRenderOptions> {
             try {
                 await navigator.serviceWorker.register(serviceWorkerUrl, { scope: "/" });
                 BackendManager.channel = makeChannel({ serviceWorker: this.config.channelOptions })!;
-            } catch (error: any) {
+            } catch {
                 return false;
             }
         } else {

src/Translations.js

@@ -1,4 +1,4 @@
-/* eslint-disable max-len */
+ 
 // Empty strings are considered missing by i18n-extract
 // Therefore the ready-key is an explicit space now, which is still invisible
 
@@ -184,7 +184,7 @@ const DUTCH_PHRASES = {
     // @codemirror/lint
     "Diagnostics": "Problemen",
     "No diagnostics": "Geen problemen",
-  }
+}
 
 const TRANSLATIONS = {
     en: { "Papyros": ENGLISH_TRANSLATION },

src/editor/CodeEditor.ts

@@ -1,4 +1,3 @@
-/* eslint-disable valid-jsdoc */
 import { ProgrammingLanguage } from "../ProgrammingLanguage";
 import { t } from "../util/Util";
 import {

src/editor/DarkTheme.ts

@@ -24,7 +24,7 @@ export const darkTheme = EditorView.theme({
     },
 
     ".cm-cursor, .cm-dropCursor": { borderLeftColor: cursor },
-    // eslint-disable-next-line max-len
+     
     "&.cm-focused .cm-selectionBackground, .cm-selectionBackground, .cm-content ::selection": { backgroundColor: selection },
 
     ".cm-panels": { backgroundColor: darkBackground, color: ivory },

src/input/InteractiveInputHandler.ts

@@ -75,7 +75,7 @@ export class InteractiveInputHandler extends UserInputHandler {
     protected override _render(options: RenderOptions): void {
         const buttonHTML = renderButton({
             id: SEND_INPUT_BTN_ID,
-            // eslint-disable-next-line max-len
+             
             classNames: "btn-secondary",
             buttonText: t("Papyros.enter")
         });

src/input/UserInputHandler.ts

@@ -80,7 +80,7 @@ export abstract class UserInputHandler extends Renderable<InputManagerRenderOpti
             // Focusing is a rendering operation
             // Subclasses can execute code after this operation, skipping the rendering
             // Using setTimeout ensures rendering will be done when the main thread has time
-            // eslint-disable-next-line max-len
+             
             // More info here: https://stackoverflow.com/questions/1096436/document-getelementbyidid-focus-is-not-working-for-firefox-or-chrome
             setTimeout(() => this.focus(), 0);
         }

src/util/Rendering.ts

@@ -1,4 +1,4 @@
-/* eslint-disable max-len */
+ 
 import { getElement } from "./Util";
 import escapeHTML from "escape-html";
 

src/util/Util.ts

@@ -137,7 +137,7 @@ export function cleanCurrentUrl(endingSlash = false): string {
  * @param {HTMLElement} el The element to focus
  */
 export function placeCaretAtEnd(el: HTMLElement): void {
-    // eslint-disable-next-line max-len
+     
     // Source: https://stackoverflow.com/questions/4233265/contenteditable-set-caret-at-the-end-of-the-text-cross-browser
     el.focus();
     if (typeof window.getSelection !== "undefined" &&