feat: pool upgrade settings, separate rbac_enabled for azure_active_directory_role_based_access_control, node_count as output parameter #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a current azurerm without explicit upgrade settings will remove
default upgrade settings:
Terraform will perform the following actions:
~ resource "azurerm_kubernetes_cluster" "k8s" {
~ default_node_pool {
- upgrade_settings {
- drain_timeout_in_minutes = 0 -> null
- max_surge = "10%" -> null
- node_soak_duration_in_minutes = 0 -> null
}
}
}
Plan: 0 to add, 1 to change, 0 to destroy.
This feature makes adding upgrade settings configurable
…sed_access_control independent from role_based_access_control_enabled Documentation was generated with the terraform module tool
|
@timdeluxe @ThomasMinor @dploeger |
ThomasMinor
approved these changes
Feb 13, 2025
timdeluxe
requested changes
Feb 13, 2025
kpshjk
force-pushed
the
default_node_pool_upgrade_settings_max_surge
branch
from
5a7b322 to
0223bae
Compare
timdeluxe
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several features and fixes an issue.
After discussion with @dploeger I put it altogether in this PR, because in 1 commit I regenerated the documentation, which would introduce merge conflicts, if each commit was in its own PR.
feat: configure adding default node pool upgrade settings
feat: use input parameter node_count as output parameter
feat: configure azure_rbac_enabled for azure_active_directory_role_ba…
fix: The temporary_name_for_rotation value must not be null