Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow package ensure parameter to be configured #15

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: Allow package ensure parameter to be configured #15

merged 1 commit into from
Feb 6, 2025

Conversation

dploeger
Copy link
Member

@dploeger dploeger commented Feb 5, 2025

No description provided.

timdeluxe
timdeluxe approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@timdeluxe timdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎁

@dploeger
Copy link
Member Author

dploeger commented Feb 6, 2025

Sorry, should've made this a draft. Somehow the ruby tests won't run. I'm on it.

@dploeger dploeger marked this pull request as draft February 6, 2025 07:47
@dploeger dploeger force-pushed the feature/dpr/package-ensure branch from fc7e47c to bf879fa Compare February 6, 2025 08:24
@dploeger dploeger marked this pull request as ready for review February 6, 2025 08:27
@dploeger dploeger marked this pull request as draft February 6, 2025 08:27
@dploeger dploeger force-pushed the feature/dpr/package-ensure branch from bf879fa to 2410aa5 Compare February 6, 2025 08:28
@dploeger dploeger marked this pull request as ready for review February 6, 2025 08:45
@dploeger
Copy link
Member Author

dploeger commented Feb 6, 2025

Now we're ready.

@dploeger dploeger requested a review from ThomasMinor February 6, 2025 08:46
@dploeger dploeger merged commit d8d404d into main Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeluxe timdeluxe timdeluxe approved these changes

@ThomasMinor ThomasMinor ThomasMinor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dploeger @timdeluxe @ThomasMinor