Migrate to Doctrine CS 10.0 #9866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, PHPUnit 7 does not understand those collapsed doc blocks. The failing tests that we see on the PHP 7.1 run are annotated with /** @requires PHP 8.1 */ |
derrabus
force-pushed
the
bump/doctrine-cs
branch
from
a5c3a2c to
ae0f0ff
Compare
|
I've reverted the single-line annotations on the PHPUnit tests and configured the exclusion rules for the corresponding sniff accordingly. |
derrabus
force-pushed
the
bump/doctrine-cs
branch
from
ae0f0ff to
ed89031
Compare
derrabus
force-pushed
the
bump/doctrine-cs
branch
from
ed89031 to
005c7df
Compare
|
Replaced by #10009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened this draft PR to monitor how Doctrine CS 10.0 at its current state would affect our codebase.
The biggest change that we can see currently is that a lot more multi-line doc blocks are collapsed to a single line.
cc @simPod @greg0ire