Make doctrine/annotations an optional dependency #8787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
requested changes
Jun 25, 2021
| reasons. Note that ``doctrine/annotations`` is not require by Doctrine | ||
| ORM, and you will need to require that package if you want to use | ||
| annotations. Doctrine ORM docblock annotations support namespaces and | ||
| nested annotations among other things. The Doctrine ORM ORM defines its |
There was a problem hiding this comment.
Suggested change
| nested annotations among other things. The Doctrine ORM ORM defines its | |
| nested annotations among other things. The Doctrine ORM defines its |
First, there are other drivers than the annotations-based one, and second, one of them is base on attributes, which are basically annotations native to PHP. Closes doctrine#8785
greg0ire
force-pushed
the
optional-doctrine-annotations
branch
from
9665a68 to
fa583f6
Compare
SenseException
approved these changes
Jun 26, 2021
This was referenced Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, there are other drivers than the annotations-based one, and
second, one of them is base on attributes, which are basically
annotations native to PHP.
Closes #8785