Skip to content

Commit

Permalink
Merge branch '2.13.x' into 2.14.x
Browse files Browse the repository at this point in the history
* 2.13.x:
  Bump Ubuntu version and shared workflows (#10020)
  Fail gracefully if EM could not be constructed in tests (#10008)
  • Loading branch information
derrabus committed Aug 30, 2022
2 parents 8d03f8f + 5d11648 commit 7a9037e
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 14 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/coding-standard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,4 @@ on:

jobs:
coding-standards:
uses: "doctrine/.github/.github/workflows/[email protected]"
with:
php-version: "8.1"
uses: "doctrine/.github/.github/workflows/[email protected]"
12 changes: 6 additions & 6 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
phpunit-smoke-check:
name: "PHPUnit with SQLite"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

strategy:
matrix:
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:

phpunit-postgres:
name: "PHPUnit with PostgreSQL"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"
needs: "phpunit-smoke-check"

strategy:
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:

phpunit-mariadb:
name: "PHPUnit with MariaDB"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"
needs: "phpunit-smoke-check"

strategy:
Expand Down Expand Up @@ -218,7 +218,7 @@ jobs:

phpunit-mysql:
name: "PHPUnit with MySQL"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"
needs: "phpunit-smoke-check"

strategy:
Expand Down Expand Up @@ -301,7 +301,7 @@ jobs:

phpunit-lower-php-versions:
name: "PHPUnit with SQLite"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

strategy:
matrix:
Expand Down Expand Up @@ -334,7 +334,7 @@ jobs:

upload_coverage:
name: "Upload coverage to Codecov"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"
needs:
- "phpunit-smoke-check"
- "phpunit-postgres"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/phpbench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:
jobs:
phpbench:
name: "PHPBench"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-on-milestone-closed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
release:
uses: "doctrine/.github/.github/workflows/release-on-milestone-closed.yml@1.4.1"
uses: "doctrine/.github/.github/workflows/release-on-milestone-closed.yml@2.0.0"
secrets:
GIT_AUTHOR_EMAIL: ${{ secrets.GIT_AUTHOR_EMAIL }}
GIT_AUTHOR_NAME: ${{ secrets.GIT_AUTHOR_NAME }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
static-analysis-phpstan:
name: "Static Analysis with PHPStan"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

strategy:
fail-fast: false
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:

static-analysis-psalm:
name: "Static Analysis with Psalm"
runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

strategy:
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion tests/Doctrine/Tests/OrmFunctionalTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ protected function setUpDBALTypes(): void

final protected function isQueryLogAvailable(): bool
{
return $this->_em->getConnection() instanceof DbalExtensions\Connection;
return $this->_em && $this->_em->getConnection() instanceof DbalExtensions\Connection;
}

final protected function getQueryLog(): QueryLog
Expand Down

0 comments on commit 7a9037e

Please sign in to comment.