This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Fix wrong name for $bucketAuto pipeline stage #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
fix-bucket-auto-stage-name
branch
from
f24a0ee to
0c48134
Compare
malarzm
approved these changes
Oct 4, 2017
jmikola
approved these changes
Oct 4, 2017
| * | ||
| * @return string | ||
| */ | ||
| abstract protected function getStageName(); |
There was a problem hiding this comment.
AbstractBucket is annotated with @internal so I wouldn't even consider this a BC break.
There was a problem hiding this comment.
Oh, I missed that completely. Even better! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather silly copy/paste mistake on my part. I'll note that this fix technically constitutes a BC break, as we're adding a new abstract method to a class. Given the lack of bug reports and the fact that ODM 1.2 with support for the aggregation framework still hasn't hit yet, i'm willing to push the fix this way. Other option would be to have
getStageNamenon-abstract and return$bucketinAbstractBucketand only override the method inBucketAuto.